Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/17128-ordinal-toValue #18273

Merged
merged 1 commit into from Jan 12, 2023
Merged

bugfix/17128-ordinal-toValue #18273

merged 1 commit into from Jan 12, 2023

Conversation

karolkolodziej
Copy link
Contributor

Fixed #17128, zooming was inaccurate when ordinal was enabled with series like flag or scatter.

@karolkolodziej karolkolodziej self-assigned this Jan 10, 2023
@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highstock.js 132.9 kB
401.3 kB		 133.0 kB
401.3 kB		 19 B
39 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

TorsteinHonsi
TorsteinHonsi approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit 5c80735 into master Jan 12, 2023
@highsoft-bot highsoft-bot added this to the Next milestone Jan 12, 2023
@TorsteinHonsi TorsteinHonsi deleted the bugfix/17128-ordinal-toValue branch January 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees

@karolkolodziej karolkolodziej

Labels
None yet
Projects
None yet
Milestone
v10.3.3
Development

Successfully merging this pull request may close these issues.

Zoom with flags
3 participants
@karolkolodziej @highsoft-bot @TorsteinHonsi