Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/14080-bubblelegend-prevent-default-click #18765

Merged
merged 1 commit into from Mar 31, 2023
Merged

bugfix/14080-bubblelegend-prevent-default-click #18765

merged 1 commit into from Mar 31, 2023

Conversation

hubertkozik
Copy link
Member

@hubertkozik hubertkozik commented Mar 30, 2023 •
edited by TorsteinHonsi

Fixed #14080, bubble legend didn't work correctly if the legendItemClick event for one series was prevented.

@hubertkozik hubertkozik added Product: Highcharts Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. labels Mar 30, 2023
@hubertkozik hubertkozik self-assigned this Mar 30, 2023
@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 100.2 kB
296.6 kB		 100.2 kB
296.6 kB		 20 B
12 B
highstock.js 133.1 kB
401.5 kB		 133.1 kB
401.5 kB		 18 B
12 B
highmaps.js 126.2 kB
382.8 kB		 126.3 kB
382.8 kB		 72 B
48 B
highcharts-gantt.js 135.6 kB
406.4 kB		 135.6 kB
406.5 kB		 18 B
12 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@hubertkozik hubertkozik marked this pull request as ready for review March 30, 2023 08:19
@TorsteinHonsi TorsteinHonsi merged commit 971a351 into master Mar 31, 2023
@highsoft-bot highsoft-bot added this to the Next milestone Mar 31, 2023
@TorsteinHonsi TorsteinHonsi deleted the bugfix/14080-bubblelegend-prevent-default-click branch March 31, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees

@hubertkozik hubertkozik

Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts
Projects
None yet
Milestone
v11.0.0
Development

Successfully merging this pull request may close these issues.

BubbleLegends hides when clicking the last legend, even if I prevent the event from happening
3 participants
@hubertkozik @highsoft-bot @TorsteinHonsi