data/json-connector #19560
Merged
data/json-connector #19560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size comparisonSizes for compiled+gzipped (bold) and compiled files.
|
Visual test results - No difference foundSamples changed
|
pawellysy
changed the title
|
Looks good. Thinks that might be considered:
|
pawellysy
force-pushed
the
data/json-connector
branch
from
4fae180
to
7e2ffaa
Compare
pawellysy
requested review from
bre1470,
vazonik,
karolkolodziej,
sebastianbochan and
goransle
karolkolodziej
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Make sure the API documentation is generated properly. Add JSON here: https://api.highcharts.com/dashboards/#interfaces/Data_DataPoolOptions.DataPoolOptions-1
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
Co-authored-by: Karol Kołodziej <57004120+karolkolodziej@users.noreply.github.com>
bre1470
requested changes
Aug 29, 2023
karolkolodziej
approved these changes
Aug 30, 2023
sebastianbochan
requested changes
Aug 30, 2023
samples/highcharts/data-tools/datapool-json-connector-orientation/demo.js
Outdated
Show resolved
Hide resolved
bre1470
approved these changes
Aug 30, 2023
|
Nice work! |
goransle
approved these changes
Aug 31, 2023
sebastianbochan
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the JSON Connector for the Dashboards.