Tools: Product-specific visual comparison #19990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bre1470
changed the title
TorsteinHonsi
requested changes
Nov 2, 2023
Visual test results - No difference foundSamples changed
|
bre1470
force-pushed
the
tools/product-visual-ci
branch
from
233a568
to
42c6ef7
Compare
goransle
reviewed
Nov 6, 2023
|
I moved file size comparison into its own workflow, so that we can keep both, Highcharts and Dashboards, in that regard together while visuals are separate. |
File size comparisonNo differences found |
goransle
reviewed
Nov 10, 2023
| .split('\n') | ||
| .filter(match => !!match), | ||
| ...ChildProcess | ||
| .execSync('git diff refs/heads/master HEAD --name-only --diff-filter=ACM') |
There was a problem hiding this comment.
Still see some git weirdness here.
Locally this worked for me on a single-branch checkout clone:
git remote set-branches origin 'master'
git fetch -v --depth=1
git diff HEAD origin/master
bre1470
force-pushed
the
tools/product-visual-ci
branch
from
1ad4536
to
96a24ca
Compare
bre1470
force-pushed
the
tools/product-visual-ci
branch
from
96a24ca
to
55bac73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.