Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/20792-plotline-html-labels #20814

Merged
merged 7 commits into from Mar 21, 2024
Merged

bugfix/20792-plotline-html-labels #20814

merged 7 commits into from Mar 21, 2024

Conversation

hubertkozik
Copy link
Member

@hubertkozik hubertkozik commented Mar 11, 2024 •
edited by TorsteinHonsi

Fixed #20792, plot lines' HTML labels rendered incorrectly.

@hubertkozik hubertkozik added Product: Highcharts Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. labels Mar 11, 2024
@hubertkozik hubertkozik self-assigned this Mar 11, 2024
@highsoft-bot
Copy link
Collaborator

Webpack monitoring

LGTM 👍

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Mar 11, 2024 •
edited

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 95.3 kB
268.5 kB		 95.3 kB
268.5 kB		 4 B
13 B
highstock.js 128.2 kB
370.4 kB		 128.2 kB
370.4 kB		 3 B
13 B
highmaps.js 121.0 kB
347.6 kB		 121.0 kB
347.6 kB		 4 B
13 B
highcharts-gantt.js 130.3 kB
375.6 kB		 130.3 kB
375.6 kB		 3 B
13 B

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Mar 11, 2024 •
edited

Visual test results - No difference found

MarkusBarstad
MarkusBarstad approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@MarkusBarstad MarkusBarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well!

goransle
goransle approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@goransle goransle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hubertkozik hubertkozik marked this pull request as ready for review March 21, 2024 08:29
TorsteinHonsi
TorsteinHonsi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit 649ec9d into master Mar 21, 2024
12 of 13 checks passed
@TorsteinHonsi TorsteinHonsi deleted the bugfix/20792-plotline-html-labels branch March 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

@goransle goransle goransle approved these changes

@MarkusBarstad MarkusBarstad MarkusBarstad approved these changes

Assignees

@hubertkozik hubertkozik

Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotlines with HTML labels render incorrectly (11.4.0 regression)
5 participants
@hubertkozik @highsoft-bot @TorsteinHonsi @goransle @MarkusBarstad