Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash/unify-datagrid-css #21076

Merged
merged 1 commit into from May 7, 2024
Merged

dash/unify-datagrid-css #21076

merged 1 commit into from May 7, 2024

Conversation

karolkolodziej
Copy link
Contributor

@karolkolodziej karolkolodziej commented Apr 26, 2024

Unified data grid CSS URLs.


@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Apr 26, 2024

Visual test results - Differences found

Found 2 diffing sample(s). Please review the differences.

@highsoft-bot
Copy link
Collaborator

Webpack monitoring

LGTM 👍

@highsoft-bot
Copy link
Collaborator

File size comparison

No differences found

@highsoft-bot
Copy link
Collaborator

Dashboard visual diffs

No differences found

@highsoft-bot
Copy link
Collaborator

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 203.34 188.11 -15.23
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 441.66 455.45 13.79
dom-size – score 1 1 0.00
dom-size – elements 346 346 0.00

@sebastianbochan
Copy link
Contributor

Waiting for the re-run broken test.

@sebastianbochan sebastianbochan merged commit 74a32d2 into master May 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants