Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/20624-treemap-drill-to-last-leaf #21102

Merged
merged 8 commits into from
May 28, 2024

Conversation

hubertkozik
Copy link
Member

@hubertkozik hubertkozik commented May 1, 2024

Added new option treemap.traverseToLeaf which allows to drill into last possible leaf of Treemap series.


@hubertkozik hubertkozik added Product: Highcharts Changelog: Feature Use on PR to add description as a feature in the generated changelog. labels May 1, 2024
@hubertkozik hubertkozik self-assigned this May 1, 2024
@highsoft-bot
Copy link
Collaborator

File size comparison

No differences found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 1, 2024

Visual test results - No difference found


Samples changed

Change type Sample
Modified samples/highcharts/plotoptions/treemap-traverse-to-leaf/demo.js
? samples/highcharts/plotoptions/treemap-zoomtolastleaf/demo.js
Modified samples/highcharts/plotoptions/treemap-zoomtolastleaf/demo.js
Added samples/highcharts/plotoptions/treemap-zoomtolastleaf/demo.js

@MarkusBarstad
Copy link
Contributor

MarkusBarstad commented May 6, 2024

Cool stuff, it works well! Just a couple of minor things

Copy link
Contributor

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

ts/Series/Treemap/TreemapSeriesDefaults.ts Outdated Show resolved Hide resolved
@hubertkozik hubertkozik marked this pull request as ready for review May 10, 2024 09:59
@TorsteinHonsi
Copy link
Collaborator

TorsteinHonsi commented May 13, 2024

Thanks! All good in the code, but some notes on the naming:

  • In the description for the changelog, the name drillToLastLeaf is used.
  • In the code, it is zoomToLastLeaf.
  • In the past, we have tried to use the term traversing constantly for drilling into a tree map. This is because it is technically not the same operation as the drilldown of the Drilldown module. We wanted to avoid confusion between the two. While the Drilldown module exchanges a point for a whole new series, the traversing of a treemap just changes the root node of the tree. So this new feature, isn't it really about traversing? Zooming indicates a purely visual operation, that we just change the view without changing the tree itself. An option that is related to this new feature is allowTraversingTree.

@hubertkozik
Copy link
Member Author

@TorsteinHonsi what do you think about changing the name of a new option to traverseToLastLeaf? I agree, that the word zoom can be wrong.

@TorsteinHonsi
Copy link
Collaborator

TorsteinHonsi commented May 14, 2024

traverseToLastLeaf sounds good.

Or, wait a minute - isn't "last leaf" redundant? I mean a leaf is by definition the last node on a branch, right? So traverseToLeaf should be sufficient?

@hubertkozik hubertkozik requested review from TorsteinHonsi and removed request for TorsteinHonsi May 28, 2024 08:24
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the hands-on demo not working since the name change, everything looks good!

On a small note, Øystein and I discussed that this option does two things:

  • Allows traversing to the leaf
  • Changes clicking to go directly to the leaf (skipping intermediate levels)
    We agreed that in the future, if someone wants to split this functionality, we can introduce string/enum settings for the option. Something like

traverseToLeaf: boolean|'directly'|'stepwise'

Co-authored-by: Torstein Hønsi <torstein@highsoft.com>
@hubertkozik
Copy link
Member Author

hubertkozik commented May 28, 2024

Whoops, sorry with the option name in the demo, too many changes of name, and here's the result 😁 About future, do you think we should create a Feature Request ticket with that idea or maybe simply add it to Asana?

@TorsteinHonsi
Copy link
Collaborator

About future, do you think we should create a Feature Request ticket with that idea or maybe simply add it to Asana?

I don't think we need to record it anywhere. Let's just wait until someone requests it, most likely they never will.

@TorsteinHonsi TorsteinHonsi merged commit e25d74c into master May 28, 2024
13 checks passed
@TorsteinHonsi TorsteinHonsi deleted the feature/20624-treemap-drill-to-last-leaf branch May 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Feature Use on PR to add description as a feature in the generated changelog. Product: Highcharts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants