-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/20624-treemap-drill-to-last-leaf #21102
feature/20624-treemap-drill-to-last-leaf #21102
Conversation
File size comparisonNo differences found |
Visual test results - No difference foundSamples changed
|
Cool stuff, it works well! Just a couple of minor things |
samples/highcharts/plotoptions/treemap-zoomtolastleaf/demo.html
Outdated
Show resolved
Hide resolved
samples/highcharts/plotoptions/treemap-zoomtolastleaf/demo.details
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Thanks! All good in the code, but some notes on the naming:
|
@TorsteinHonsi what do you think about changing the name of a new option to |
Or, wait a minute - isn't "last leaf" redundant? I mean a leaf is by definition the last node on a branch, right? So |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the hands-on demo not working since the name change, everything looks good!
On a small note, Øystein and I discussed that this option does two things:
- Allows traversing to the leaf
- Changes clicking to go directly to the leaf (skipping intermediate levels)
We agreed that in the future, if someone wants to split this functionality, we can introduce string/enum settings for the option. Something like
traverseToLeaf: boolean|'directly'|'stepwise'
samples/highcharts/plotoptions/treemap-traverse-to-leaf/demo.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Torstein Hønsi <torstein@highsoft.com>
Whoops, sorry with the option name in the demo, too many changes of name, and here's the result 😁 About future, do you think we should create a Feature Request ticket with that idea or maybe simply add it to Asana? |
I don't think we need to record it anywhere. Let's just wait until someone requests it, most likely they never will. |
Added new option
treemap.traverseToLeaf
which allows to drill into last possible leaf of Treemap series.