-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dash/datagrid2 #21182
base: master
Are you sure you want to change the base?
dash/datagrid2 #21182
Conversation
File size comparisonSizes for compiled+gzipped (bold) and compiled files.
|
Visual test results - No difference found |
Dash/datagrid2 benchmark
|
||
if (value !== void 0) { | ||
if (key === 'style') { | ||
Object.assign(element.style, value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spread operator should be faster.
const element = document.createElement(tagName); | ||
|
||
if (params) { | ||
const paramsKeys = Object.keys( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try to test Object.entries
instead. It should be faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
- When writing api docs please stick to the convention:
/**
* Constructs a row in the data grid.
*
* @param dataGrid
* The data grid instance which the row belongs to.
*
* @param index
* The index of the row in the data table.
*/
- I would like to have some convention about the class lifecycle methods:
- have "light"
constructor
that callsinit
init
should set some basic options and callload
and/orrender
update
method is missingreflow
I don't like it, buf if we need it let's keep itdestroy
is missing?
public viewport: DataGridTable; | ||
|
||
/** | ||
* The width ratio of the column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain a bit more what it does and why?
As far as I see there is no way to set it right?
/** | ||
* Whether the row is destroyed. | ||
*/ | ||
public destroyed: boolean = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
destroyed
for me seems permanent and completed, I would use something like removed/hidden/notVisibleInViewport?
…w-heights dash/datagrid2-different-row-heights
…scrolling dash/datagrid2-td-resizing-scrolling
dash/datagrid2-styles
WiP
(ToDo list moved to Asana)