Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo/area-chart-seo #21183

Merged
merged 3 commits into from
May 28, 2024
Merged

demo/area-chart-seo #21183

merged 3 commits into from
May 28, 2024

Conversation

hubertkozik
Copy link
Member

@hubertkozik hubertkozik commented May 17, 2024

Changed title and URL.


@hubertkozik hubertkozik self-assigned this May 17, 2024
@hubertkozik hubertkozik changed the title demo/area-chart-sero demo/area-chart-seo May 17, 2024
@highsoft-bot
Copy link
Collaborator

File size comparison

No differences found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented May 17, 2024

Visual test results - No difference found


Samples changed

Change type Sample
? samples/highcharts/demo/area-basic/demo.js
Modified samples/highcharts/demo/area-basic/demo.js
Modified samples/highcharts/demo/area-basic/demo.js

@hubertkozik hubertkozik marked this pull request as ready for review May 27, 2024 06:32
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is the limited instruction in Asana:

Change URL and title for the sake of SEO to "Area Chart"

What I meant was

  • "Change URL": I meant the path for the demo itself. So instead of highcharts/demo/area-basic, the folder should be renamed to highcharts/demo/area-chart.
  • "... and title". I meant the name field in demo.details, the one that currently says "Basic area".

The rationale for the changes is that people are likely to google for "area chart".

@TorsteinHonsi TorsteinHonsi merged commit 6583812 into master May 28, 2024
13 checks passed
@TorsteinHonsi TorsteinHonsi deleted the demo/area-chart-sero branch May 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants