feature/stock-tools-update-perfo #21204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size comparisonNo differences found |
Visual test results - No difference found |
Benchmark report - Stockbenchmarks/Stock/Stock-Base.bench.ts
See all
|
bm64
changed the title
pawellysy
requested changes
May 28, 2024
ts/Stock/StockTools/StockToolbar.ts
Outdated
Comment on lines
751
to
785
| if (this.options.className !== this.guiClassName) { | ||
| if (this.guiClassName) { | ||
| this.wrapper.classList.remove(this.guiClassName); | ||
| } | ||
| if (this.options.className) { | ||
| this.wrapper.classList.add(this.options.className); | ||
| } | ||
| this.guiClassName = this.options.className; | ||
| } | ||
|
|
||
| if (this.options.toolbarClassName !== this.toolbarClassName) { | ||
| if (this.toolbarClassName) { | ||
| this.toolbar.classList.remove(this.toolbarClassName); | ||
| } | ||
| if (this.options.toolbarClassName) { | ||
| this.toolbar.classList.add(this.options.toolbarClassName); | ||
| } | ||
| this.toolbarClassName = this.options.toolbarClassName; | ||
| } | ||
|
|
||
| if ( | ||
| !shallowArraysEqual(this.options.buttons, this.buttonList) || | ||
| this.isDirty | ||
| ) { | ||
| this.toolbar.innerHTML = AST.emptyHTML; | ||
| this.createButtons(); | ||
| } | ||
|
|
||
| if (this.options.enabled === false) { | ||
| this.destroy(); | ||
| } | ||
|
|
||
| if (defined(this.options.visible)) { | ||
| this.visible = this.options.visible; | ||
| } |
There was a problem hiding this comment.
There are a lot of if statements here. Would you mind splitting that into separate methods to improve code readability?
pawellysy
requested changes
Jun 5, 2024
ts/Stock/StockTools/StockToolbar.ts
Outdated
Comment on lines
515
to
522
| chart.update({ | ||
| stockTools: { | ||
| gui: { | ||
| visible: !self.visible, | ||
| placed: true | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
StockTools has it's update method. Maybe we could use that to avoid some unnecessary logic?
PS: there is no placed property in the API. Should it be there?
kamil-musialowski
requested changes
Jun 6, 2024
ts/Stock/StockTools/StockToolbar.ts
Outdated
| container.appendChild(wrapper); | ||
|
|
||
| this.showhideBtn = createElement('div', { |
There was a problem hiding this comment.
Is it showhideBtn on purpose, or should it be showHideBtn?
ts/Stock/StockTools/StockToolsGui.ts
Outdated
| @@ -144,20 +143,29 @@ function onChartAfterGetContainer( | |||
| function onChartBeforeRedraw( | |||
| this: Chart | |||
| ): void { | |||
| if (this.stockTools) { | |||
| onChartRedraw.call(this); | |||
| if (this.stockTools && this.stockTools.guiEnabled) { | |||
There was a problem hiding this comment.
Can we change it to optional chaining?
Suggested change
| if (this.stockTools && this.stockTools.guiEnabled) { | |
| if (this.stockTools?.guiEnabled) { |
ts/Stock/StockTools/StockToolbar.ts
Outdated
| const chart = this.chart, | ||
| guiOptions = this.options, | ||
| container = chart.container, | ||
| navigation = chart.options.navigation, | ||
| bindingsClassName = navigation && navigation.bindingsClassName; | ||
| bindingsClassName = navigation && navigation.bindingsClassName, |
There was a problem hiding this comment.
Suggested change
| bindingsClassName = navigation && navigation.bindingsClassName, | |
| bindingsClassName = navigation?.bindingsClassName, |
ts/Stock/StockTools/StockToolbar.ts
Outdated
| * Remove highcharts-active class from button. | ||
| * @private | ||
| */ | ||
| public removeButtonActiveClass( |
There was a problem hiding this comment.
I'm afraid that 4fd095a removed the usage of this method, and we just have a function, but it's not used anywhere.
So we either need to remove this function, or revert the changes from the commit that removed the usage.
pawelfus
requested changes
Jun 6, 2024
pawelfus
requested changes
Jun 14, 2024
ts/Stock/StockTools/StockToolsGui.ts
Outdated
| offsetWidth = listWrapper && ( | ||
| this.stockTools.redraw(); | ||
|
|
||
| if (this.stockTools.guiEnabled) { |
There was a problem hiding this comment.
Q: What do you think about extracting the whole code below to a function, eg setOffset() or calculateOffset()?
kamil-musialowski
approved these changes
Jun 14, 2024
| * | ||
| * @type {boolean} |
There was a problem hiding this comment.
Removing that @type was on purpose? 🤔
pawellysy
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance stock tools with optimized update and redraw functionality.