DO NOT MERGE YET: bugfix/crooked-navigator-outline

[bm64]

Corrected crooked line in the navigator outline.

Note to self: Because of the large number of visual diff (mostly 1px), do not merge this until after the next release has been auto-visually tested, but before the manual tests.

[highsoft-bot]

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

	master	candidate	difference
highstock.js	128.9 kB 372.6 kB	128.9 kB 372.6 kB	-1 B -2 B
highcharts-gantt.js	134.1 kB 386.6 kB	134.1 kB 386.6 kB	-2 B -2 B
modules/accessibility.js	37.5 kB 136.2 kB	37.5 kB 136.2 kB	-1 B -2 B

[highsoft-bot]

Visual test results - Differences found

Found 314 diffing sample(s). Please review the differences.

[highsoft-bot]

Benchmark report - Stock

benchmarks/Stock/Stock-DataGrouping.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000000	1049.19	1040.73	8.46	1%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000	254.8	255.81	-1.01	0%
10000	266.6	265.08	1.52	1%
100000	351.24	352.54	-1.29	0%
1000000	1049.19	1040.73	8.46	1%

benchmarks/Stock/Stock-Base.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000000	6094.56	6178.69	-84.13	-1%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000	260.2	265.52	-5.32	-2%
10000	348.57	350.09	-1.51	0%
100000	911.57	913.24	-1.68	0%
1000000	6094.56	6178.69	-84.13	-1%

benchmarks/Stock/Stock-Ordinal.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000000	1411.18	1422.2	-11.02	-1%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000	268.88	269.94	-1.06	0%
10000	289.1	288.68	0.42	0%
100000	458.1	450.79	7.31	2%
1000000	1411.18	1422.2	-11.02	-1%

benchmarks/Stock/Stock-DataGrouping-Ordinal.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000000	1440.67	1416.26	24.41	2%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
1000	270.77	268.76	2.02	1%
10000	287	287.8	-0.8	0%
100000	459.08	457.66	1.42	0%
1000000	1440.67	1416.26	24.41	2%

[TorsteinHonsi]

Looks good, but the visual diff preview is down now so I can't verify.

[TorsteinHonsi]

Thanks!

Our test suite takes some time to run, mainly because of the time it takes to generate the charts for each test. Therefore we have a policy to try to reuse existing charts for new regression tests. Can you find a similar test and apply the assertion there instead of creating a whole new test with a stock chart?

[TorsteinHonsi]

Thanks! Can you take a look at the conflicts too?