dash/edit-mode-context

[karolkolodziej]

Added context detection for custom HTML.

[highsoft-bot]

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

	master	candidate	difference
dashboards/dashboards.js	43.2 kB 148.8 kB	43.5 kB 149.5 kB	244 B 720 B
dashboards/modules/layout.js	12.3 kB 48.2 kB	12.7 kB 49.6 kB	435 B 1451 B

[highsoft-bot]

Lighthouse report

dashboards-demo-minimal.json

	Reference	Proposed	Diff
performance – score	1	1	0.00
first-contentful-paint – score	1	1	0.00
first-contentful-paint – milliseconds	218.94	193.36	-25.58
first-meaningful-paint – score	1	1	0.00
first-meaningful-paint – milliseconds	435.78	443.32	7.54
dom-size – score	1	1	0.00
dom-size – elements	344	344	0.00

[highsoft-bot]

Dashboard visual diffs

Visual differences found in:

• /home/runner/work/highcharts/highcharts/cypress/snapshots/actual/test/cypress/dashboards/visual/dashboards-demo-minimal-loaded.png

See artifacts in the run summary for screenshots

[highsoft-bot]

Visual test results - No difference found

---

Samples changed

Change type	Sample
Modified	samples/highcharts/website/small-demos-dashboards/demo.js

[highsoft-bot]

Benchmark report - Dashboards

benchmarks/Dashboards/DataPool-CSV-constructor.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
2500000	0.17	0.16	0.01	4%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
100	0.17	0.16	0.01	4%
1000	0.16	0.16	0	1%
10000	0.17	0.17	0	3%
100000	0.17	0.17	0	0%
1000000	0.17	0.17	0	-1%
2500000	0.17	0.16	0.01	4%

benchmarks/Dashboards/DataTable-loading-rows.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
2500000	747.53	748.06	-0.54	0%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
100	0.29	0.29	0	-1%
1000	0.56	0.58	-0.02	-3%
10000	3.81	4.35	-0.54	-12%
100000	21.59	21.21	0.38	2%
1000000	296.17	291.96	4.2	1%
2500000	747.53	748.06	-0.54	0%

benchmarks/Dashboards/DataTable-loading-columns.bench.ts

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
2500000	16.93	16.18	0.75	5%

See all

Sample size	This PR avg (ms)	master avg (ms)	Diff	Percent diff
100	0.24	0.24	0	-2%
1000	0.24	0.25	-0.01	-5%
10000	0.28	0.45	-0.17	-38%
100000	2.28	2.31	-0.04	-2%
1000000	9.16	9.06	0.09	1%
2500000	16.93	16.18	0.75	5%

[stitot]

Really nice!

One thing: if divs in the layout have a high z-index then menu, icons, sidebar etc. will render behind those elements. Perhaps not possible to solve 100%, but we could limit the problem by setting z-index: 1000000000 on those elements. Could be many reasons for devs to use high z-indexes in their layouts, and they often use them in steps of 10 or 100 to have some leverage.

[stitot]

I meant it when I said "1000000000" ;-)

For this to actually reduce cases of overlap due to high z-index in customers layout I believe it must be much higher than 100.

[sebastianbochan]

The zIndex like 1000000000 does not make sense, because the maximum value is limited. I suggest setting the value 9999.

[stitot]

The zIndex like 1000000000 does not make sense, because the maximum value is limited. I suggest setting the value 9999.

@karolkolodziej mentioned there was maybe a more elegant solution than this "brute force" one.

[sebastianbochan]

Looks good to me.

[stitot]

I would like to understand your reluctance to set this higher. Value for z-index is an integer, so can be −2147483648 to +2147483647 without breaking the rules. Could we at least add some 9's, so that the value is 9999999? The higher the better, as it will cover more cases. Your call.