Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/puppeteer-as-module #408

Merged
merged 12 commits into from Aug 29, 2023

Conversation

jszuminski
Copy link
Contributor

@jszuminski jszuminski commented Aug 1, 2023

Description

For now, the readme.md file included in the repository shows a way to use the highcharts-export-server as a node module which is no longer working in the latest v3.0.0.

The main problem is that since 3.0.0 we initialize default settings inside initPool and startExport which are supposed to be easy-to-use by the users. Merging userOptions with defaultOptions should take place somewhere else - the users should not worry about it.

  • I've added the initExportSettings method which takes care of merging userOptions with defaultOptions for chart.startExport
  • I've added initialization of the options inside the lib/index.js initPool() method

Tasks

  • Add initExportSettings method
  • Update readme.md

@jszuminski jszuminski self-assigned this Aug 1, 2023
@cvasseng
Copy link
Contributor

Is this ready for merging?

@jszuminski
Copy link
Contributor Author

Waiting for @PaulDalek's review. If @PaulDalek and you approve of this I think it's ready to merge.

@cvasseng cvasseng self-requested a review August 29, 2023 11:38
Copy link
Contributor

@cvasseng cvasseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jszuminski jszuminski merged commit 2a5d8df into enhancement/puppeteer Aug 29, 2023
@jszuminski jszuminski deleted the enhancement/puppeteer-as-module branch August 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants