New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement/puppeteer-as-module #408
Merged
jszuminski
merged 12 commits into
enhancement/puppeteer
from
enhancement/puppeteer-as-module
Aug 29, 2023
Merged
enhancement/puppeteer-as-module #408
jszuminski
merged 12 commits into
enhancement/puppeteer
from
enhancement/puppeteer-as-module
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this ready for merging? |
Waiting for @PaulDalek's review. If @PaulDalek and you approve of this I think it's ready to merge. |
cvasseng
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, the
readme.md
file included in the repository shows a way to use thehighcharts-export-server
as a node module which is no longer working in the latest v3.0.0.The main problem is that since 3.0.0 we initialize default settings inside
initPool
andstartExport
which are supposed to be easy-to-use by the users. MerginguserOptions
withdefaultOptions
should take place somewhere else - the users should not worry about it.initExportSettings
method which takes care of merginguserOptions
withdefaultOptions
forchart.startExport
lib/index.js
initPool()
methodTasks
initExportSettings
methodreadme.md