Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC health check endpoint by default #626

Closed
TannerYoung opened this issue Jul 9, 2019 · 1 comment
Closed

Support gRPC health check endpoint by default #626

TannerYoung opened this issue Jul 9, 2019 · 1 comment
Assignees

Comments

@TannerYoung
Copy link

Mu should support gRPC health checks with limited configuration (if not by default) out of the box. See https://github.com/grpc/grpc/blob/master/doc/health-checking.md for details.

This would allow dependencies to wait for the service to become healthy before sending requests to it. For example https://github.com/grpc-ecosystem/grpc-health-probe/

This could be done with a default GrpcConfig implementation to be added as a parameter to configList in GrpcServer.netty[IO](port, myService :: healthService :: Nil).

@ememmr
Copy link
Contributor

ememmr commented Aug 6, 2019

A first version of health check service: #630
Pending:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants