Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports inner imports within @service macro. #101

Merged
merged 1 commit into from Dec 19, 2017

Conversation

juanpedromoreno
Copy link
Member

This PR makes possible to have inner imports within the annotated @service trait:

@service
    trait RPCService[F[_]] {
      import ExternalScope._

      @rpc(Protobuf)
      def scope(empty: Empty.type): F[External]
    }

It also releases a new patch version -> 0.5.1.

* Releases a new patch version -> 0.5.1
@codecov-io
Copy link

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files          12       12           
  Lines         139      139           
=======================================
  Hits          116      116           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba7879...5f99887. Read the comment docs.

@eperinan eperinan self-requested a review December 19, 2017 15:38
@juanpedromoreno juanpedromoreno merged commit 616651a into master Dec 19, 2017
@juanpedromoreno juanpedromoreno deleted the jp-support-service-imports branch December 19, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants