Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Empty.type Request/Response #105

Merged
merged 2 commits into from Dec 26, 2017
Merged

Docs - Empty.type Request/Response #105

merged 2 commits into from Dec 26, 2017

Conversation

eperinan
Copy link
Contributor

Added a simple text and example where I try to explain that we can return an empty content as response in RPC service

It resolves frees-io/freestyle#457

@eperinan eperinan self-assigned this Dec 22, 2017
@juanpedromoreno juanpedromoreno changed the title Adds mention to empty content in rpc docs Docs - Empty.type Request/Response Dec 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #105 into master will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   85.12%   84.29%   -0.83%     
==========================================
  Files          12       12              
  Lines         121      121              
==========================================
- Hits          103      102       -1     
- Misses         18       19       +1
Impacted Files Coverage Δ
rpc/src/main/scala/internal/MonixAdapters.scala 80% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b965ac...e7ee9b0. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpedromoreno juanpedromoreno merged commit 1d5f2bc into master Dec 26, 2017
@juanpedromoreno juanpedromoreno deleted the ep-empty-docs branch December 26, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs according to object empty in freestyle-rpc
3 participants