New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splits core into Server and Client submodules #113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -39,6 +40,12 @@ trait Syntax { | |||
} | |||
} | |||
|
|||
trait IOCapture { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not related to the PR, but why is this called IOCapture
? Does it make sense to rename it?
fedefernandez
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fedefernandez
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up the current code base in different modules, mainly separating
client
andserver
. The main goal is delimiting the dependencies usage since when bootstrapping a server wedon't want the client dependencies and vice versa.
Additionally, other sub-modules have been created for the sake of simplicity.
frees-rpc-common
containing protocol types, with the minimum set of dependencies.frees-rpc-async
containing just the async implicit instances (NTs between effect/async types).frees-rpc-internal
where the macros are placed.frees-rpc-client-core
: algebra and code related to the RPC clients.frees-rpc-client-netty
: it doesn't add any additional code, just a transport layer provider based ongrpc-netty
.frees-rpc-client-okhttp
: similar to theNetty
one, it doesn't add any additional code, just a transport layer provider based ongrpc-okhttp
.frees-rpc-server
: algebra and code related to the RPC server.frees-rpc-config
: helpers to be able to load the client and the server configuration.frees-rpc-tests
: it won't be published, it just houses tests for client and server altogether.Breaking changes: algebras and handlers
TaskMHandler
,ChannelM
,ChannelMHandler
have been removed because they are not needed anymore.