Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits core into Server and Client submodules #113

Merged
merged 4 commits into from Jan 10, 2018

Conversation

juanpedromoreno
Copy link
Member

This PR splits up the current code base in different modules, mainly separating client and server. The main goal is delimiting the dependencies usage since when bootstrapping a server we
don't want the client dependencies and vice versa.

Additionally, other sub-modules have been created for the sake of simplicity.

  • frees-rpc-common containing protocol types, with the minimum set of dependencies.
  • frees-rpc-async containing just the async implicit instances (NTs between effect/async types).
  • frees-rpc-internal where the macros are placed.
  • frees-rpc-client-core: algebra and code related to the RPC clients.
  • frees-rpc-client-netty: it doesn't add any additional code, just a transport layer provider based on grpc-netty.
  • frees-rpc-client-okhttp: similar to the Netty one, it doesn't add any additional code, just a transport layer provider based on grpc-okhttp.
  • frees-rpc-server: algebra and code related to the RPC server.
  • frees-rpc-config: helpers to be able to load the client and the server configuration.
  • frees-rpc-tests: it won't be published, it just houses tests for client and server altogether.

Breaking changes: algebras and handlers TaskMHandler, ChannelM, ChannelMHandler have been removed because they are not needed anymore.

@juanpedromoreno juanpedromoreno requested a review from a team January 10, 2018 13:04
@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #113 into master will decrease coverage by 7.69%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
- Coverage   83.62%   75.92%   -7.7%     
=========================================
  Files          14       12      -2     
  Lines         116      108      -8     
=========================================
- Hits           97       82     -15     
- Misses         19       26      +7
Impacted Files Coverage Δ
...er/src/main/scala/handlers/GrpcServerHandler.scala 86.66% <ø> (ø)
modules/internal/src/main/scala/server/calls.scala 81.48% <ø> (ø)
modules/client/src/main/scala/package.scala 0% <ø> (ø)
.../src/main/scala/server/GRPCServiceDefBuilder.scala 100% <ø> (ø)
...odules/internal/src/main/scala/MonixAdapters.scala 80% <ø> (ø)
modules/server/src/main/scala/GrpcConfig.scala 100% <ø> (ø)
...dules/async/src/main/scala/RPCAsyncImplicits.scala 83.33% <ø> (ø)
modules/server/src/main/scala/package.scala 0% <ø> (ø)
modules/internal/src/main/scala/client/calls.scala 100% <ø> (ø)
modules/server/src/main/scala/implicits.scala 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d724855...841db62. Read the comment docs.

@@ -39,6 +40,12 @@ trait Syntax {
}
}

trait IOCapture {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not related to the PR, but why is this called IOCapture? Does it make sense to rename it?

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addtext_com_mtqzmzm2mtk3mg

@juanpedromoreno juanpedromoreno merged commit 211ff48 into master Jan 10, 2018
@juanpedromoreno juanpedromoreno deleted the jp-splits-core-into-server-client branch January 10, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants