Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes random test failure #147

Merged
merged 1 commit into from Jan 18, 2018
Merged

Fixes random test failure #147

merged 1 commit into from Jan 18, 2018

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Jan 18, 2018

The latest changes have been passed on Travis (14 builds in total)

@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #147 into master will decrease coverage by 4.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   92.85%   88.21%   -4.65%     
==========================================
  Files          25       25              
  Lines         266      280      +14     
  Branches        6        6              
==========================================
  Hits          247      247              
- Misses         19       33      +14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74802f6...6bb342a. Read the comment docs.

@fedefernandez fedefernandez changed the title [WIP] - Random test error Fixes random test failure Jan 18, 2018
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fedefernandez fedefernandez merged commit 48e08e3 into master Jan 18, 2018
@fedefernandez fedefernandez deleted the ff-random-test-error branch January 18, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants