Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable conditionally disabling certain tests in Travis #216

Merged
merged 7 commits into from Apr 6, 2018

Conversation

L-Lavigne
Copy link
Contributor

Also restored some tests where exceptions are expected, and restored others to see if they still fail on Travis.

@L-Lavigne
Copy link
Contributor Author

On hold for now - this properly belongs to sbt-org-policies as a change to the orgScriptCI task.

Getting parameterized testOnly to work in sbt build scripts (as opposed to command-line) turns out to be surprisingly convoluted, more so in the context of our custom build plugins. Explicitely bailing out of tests when Travis is detected is less elegant, but test cancellation provides much more useful reporting/reminders than test ignoring.
@L-Lavigne L-Lavigne removed the on hold label Apr 6, 2018
@L-Lavigne
Copy link
Contributor Author

Change of approach in latest commit:
Getting parameterized testOnly to work in sbt build scripts (as opposed to command-line) turns out to be surprisingly convoluted, more so in the context of our custom build plugins. Explicitly bailing out of tests when Travis is detected is less elegant, but test cancellation provides much more useful reporting/reminders than test ignoring.

@L-Lavigne L-Lavigne changed the title New LocalOnly test tag for tests we want to ignore on Travis Enable conditionally disabling certain tests in Travis Apr 6, 2018
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@L-Lavigne L-Lavigne merged commit de4ea42 into master Apr 6, 2018
@L-Lavigne L-Lavigne deleted the LocalTestTag branch April 6, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants