Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Definitions - Test Coverage #22

Merged
merged 2 commits into from Jul 4, 2017
Merged

Server Definitions - Test Coverage #22

merged 2 commits into from Jul 4, 2017

Conversation

juanpedromoreno
Copy link
Member

This PR adds some tests over server definitions (related to #15).

@codecov-io
Copy link

codecov-io commented Jul 4, 2017 •
edited

Codecov Report

Merging #22 into master will increase coverage by 34.78%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage       0%   34.78%   +34.78%     
===========================================
  Files          13        7        -6     
  Lines         160       46      -114     
  Branches        3        0        -3     
===========================================
+ Hits            0       16       +16     
+ Misses        160       30      -130
Impacted Files Coverage Δ
rpc/src/main/scala/server/implicits.scala 50% <100%> (+50%) ⬆️
...ng/src/main/scala/greeting/runtime/implicits.scala
.../src/main/scala/greeting/service/EchoService.scala
.../main/scala/greeting/service/GreetingService.scala
...ng/src/main/scala/greeting/GreetingServerApp.scala
...eting/src/main/scala/greeting/GreetingClient.scala
...ng/src/main/scala/greeting/GreetingClientApp.scala
...main/scala/server/handlers/GrpcServerHandler.scala 86.66% <0%> (+86.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367f907...74ee2d4. Read the comment docs.

fedefernandez
fedefernandez approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments
LGTM!

rpc/src/test/scala/server/handlers/GrpcServerHandlerTests.scala Outdated

}

"allow to stop an started GrpcServer" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a started?

rpc/src/test/scala/server/handlers/GrpcServerHandlerTests.scala Outdated

}

"allow to stop immediately an started GrpcServer" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below

rpc/src/test/scala/server/handlers/GrpcServerHandlerTests.scala Outdated

}

"allow to to terminate after a certain timeout is reached" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ~to~

@juanpedromoreno juanpedromoreno merged commit 07e91af into master Jul 4, 2017
@juanpedromoreno juanpedromoreno deleted the jp-server-defs-tests branch July 4, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedefernandez fedefernandez fedefernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanpedromoreno @codecov-io @fedefernandez