decouple from frees-async #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bring the listenableFuture2Async function to the project, and don't use frees-async-* packages
pepegar
commented
Jun 4, 2018
| @@ -79,4 +80,20 @@ object monixCalls { | |||
| outputObserver | |||
| )) | |||
| ) | |||
|
|
|||
| private[this] def listenableFuture2Async[F[_], A]( | |||
| fa: => ListenableFuture[A])(implicit F: Async[F], E: ExecutionContext): F[A] = | |||
There was a problem hiding this comment.
I've changed teh AsyncContext[F] requirement with an Async[F] requirement, which is the same idea.
There was a problem hiding this comment.
Maybe we can restrict the implicit req to the Effect typeclass?
There was a problem hiding this comment.
Effect is an Async, so it would be widening. Also, we're not using runAsync on the F, so we don't need Effect, right?
pepegar
requested review from
juanpedromoreno and
fedefernandez
and removed request for
juanpedromoreno
|
is this fixing #297 ? |
|
Ah yes, I forgot mentioning it in the comment |
|
I'd suggest removing this: https://github.com/frees-io/freestyle-rpc/blob/master/project/ProjectPlugin.scala#L54. We can use the grpc guava version, which it's already available in the classpath. |
JesusMtnez
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring the listenableFuture2Async function to the project, and don't
use frees-async-* packages
FIXES #297