Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes the basic Example #36

Merged
merged 2 commits into from Aug 11, 2017
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR completes the basic example we've been playing with. It brings some fixes and makes both server and client streaming working with Monix observables.

We're now ready for #34.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (also notice that it's failing for Scala 2.11 in Travis)
giphy

@juanpedromoreno juanpedromoreno merged commit 49c2be9 into master Aug 11, 2017
@juanpedromoreno juanpedromoreno deleted the jp-observable-example branch August 11, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants