Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First micro-site approach #407

Merged
merged 6 commits into from Oct 1, 2018
Merged

Conversation

AntonioMateoGomez
Copy link
Contributor

This is a first approach for the microsite, we still have to change the tag line in the main page, and add a proper icon for gRPC in the technologies section.
This PR:

  • Add micro-site settings.
  • Removes the old docsSettings which tutTargetDirectory was pointing to freestyle.
  • Fixes some broken links in the references.md file.

- Add micro-site settings.
- Removes the old docsSettings which tutTargetDirectory was pointing to
freestyle.
- Fixes some broken links in the references.md file.
title: Home
technologies:
- first: ["Scala", "Frees-rpc library is completely written in Scala."]
- second: ["gRPC", "Frees-rpc combine RPC protocols, services and clients thank to gRPC framework."]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace this logo with the gRPC logo, the current one that is being shown is the sbt one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-combine
+combines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know about the icon. It is commented in the PR description. Is a provisional one till @israelperezglez provides the right one.

technologies:
- first: ["Scala", "Frees-rpc library is completely written in Scala."]
- second: ["gRPC", "Frees-rpc combine RPC protocols, services and clients thank to gRPC framework."]
- third: ["Functional Programming", "Frees-rpc is implemented using the Free Monad and Interpreter pattern."]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frees-rpc is a purely functional library for building RPC endpoint based services.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.


nested_options:

- title: Quickstart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove this section since it's no longer providing useful information, pretty much is showing the same menu that the user can find on the left menu.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When going from the Home to the Documentation section, we can link directly to the Core concepts section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, It makes sense

build.sbt Outdated
addCompilerPlugin(%%("scalameta-paradise") cross CrossVersion.full),
libraryDependencies += %%("scalameta", "1.8.0"),
scalacOptions += "-Xplugin-require:macroparadise"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this entire group of settings:

  .settings(
    addCompilerPlugin(%%("scalameta-paradise") cross CrossVersion.full),
    libraryDependencies += %%("scalameta", "1.8.0"),
    scalacOptions += "-Xplugin-require:macroparadise"
  )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look on it

build.sbt Outdated
@@ -1,3 +1,4 @@
import ProjectPlugin.autoImport.micrositeSettings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't be necessary either

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this import made an ambigous reference to micrositeSettings.

it is imported twice in the same scope by
import ProjectPlugin.autoImport._
and import _root_.freestyle.FreestylePlugin.autoImport._
  .settings(micrositeSettings: _*)

To solve this I renamed the value as freesMicrositeSettings

build.sbt Outdated
.settings(
libraryDependencies ++= Seq(%%("scalamockScalatest") % "tut"),
scalacOptions in Tut ~= (_ filterNot Set("-Ywarn-unused-import", "-Xlint").contains)
)
.enablePlugins(TutPlugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could remove .enablePlugins(TutPlugin)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look on it

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @AntonioMateoGomez !

@AntonioMateoGomez AntonioMateoGomez merged commit 7ef26bc into master Oct 1, 2018
@AntonioMateoGomez AntonioMateoGomez deleted the paolo-add-microsite-structure branch October 1, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants