Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes proto code generator for repeated types #43

Merged
merged 1 commit into from Sep 7, 2017

Conversation

juanpedromoreno
Copy link
Member

This PR fixes list types as repeated (for custom types) in the generated proto files.

case class Foo(bar: List[CustomType])

Results as:

message Foo {
   repeated CustomType bar = 1;
}

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpedromoreno juanpedromoreno merged commit 75bd090 into master Sep 7, 2017
@juanpedromoreno juanpedromoreno deleted the jp-bug-fix-with-repeated branch September 7, 2017 09:35
@codecov-io
Copy link

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   10.75%   10.75%           
=======================================
  Files          20       20           
  Lines         279      279           
  Branches        0        1    +1     
=======================================
  Hits           30       30           
  Misses        249      249
Impacted Files Coverage Δ
rpc/src/main/scala/proto/converters.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1dd6c...6eb9590. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants