Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open api generation #659

Merged
merged 9 commits into from Sep 26, 2019
Merged

Open api generation #659

merged 9 commits into from Sep 26, 2019

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Sep 21, 2019

What this does?

This PR resumes the work by @BeniVF , providing support for code generation from Open API specifications.

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@juanpedromoreno
Copy link
Member Author

There still some binary issues with circe, after the recent build upgrade (previously was working).

[info] [warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] [error] java.lang.NoSuchMethodError: sbt.package$.fileJsonFormatter()Lsjsonnew/JsonFormat;
[info] [error] 	at higherkindness.mu.rpc.idlgen.IdlGenPlugin$autoImport$.srcGenSourceDirs$lzycompute(IdlGenPlugin.scala:60)
[info] [error] 	at higherkindness.mu.rpc.idlgen.IdlGenPlugin$autoImport$.srcGenSourceDirs(IdlGenPlugin.scala:59)
[info] [error] 	at $1a2dcb12ba29963163ce$.root$lzycompute(build.sbt:19)
[info] [error] 	at $1a2dcb12ba29963163ce$.root(build.sbt:11)
[info] [error] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[info] [error] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[info] [error] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@juanpedromoreno
Copy link
Member Author

Thanks @fedefernandez for the fix! Actually, I think we don't need to add the build.properties files as part of the scripted tests... as you pointed out, looks like a bug in sbt.

@juanpedromoreno
Copy link
Member Author

... and @BeniVF, thank you for your hard work in this new feature!

@juanpedromoreno juanpedromoreno marked this pull request as ready for review September 23, 2019 13:54
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a minor comment

@BeniVF BeniVF self-requested a review September 24, 2019 11:38
@juanpedromoreno
Copy link
Member Author

@BeniVF thanks for the review. I think this is now ready for a second look. Thanks.

@juanpedromoreno juanpedromoreno merged commit 67d8011 into master Sep 26, 2019
@juanpedromoreno juanpedromoreno deleted the open-api-generation branch September 26, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants