Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Avro Serialization #78

Merged
merged 2 commits into from Nov 7, 2017
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR brings support for Avro serialization.

Therefore, from now on, you can choose for your service (at @rpc level) the type of serialization. Currently: Avro or Protobuf.

@free
    @service
    trait FreesRPCService {

      @rpc(Avro) def unary(a: A): FS[C]

      @rpc(Protobuf)
      @stream[ResponseStreaming.type]
      def serverStreaming(b: B): FS[Observable[C]]

      @rpc(Protobuf)
      @stream[RequestStreaming.type]
      def clientStreaming(oa: Observable[A]): FS[D]

      @rpc(Avro)
      @stream[BidirectionalStreaming.type]
      def biStreaming(oe: Observable[E]): FS[Observable[E]]
    }

We are relying on avro4s for the binary serialization/deserialization.

@codecov-io
Copy link

codecov-io commented Nov 7, 2017

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files          12       12           
  Lines         122      122           
=======================================
  Hits          108      108           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120b821...dca115b. Read the comment docs.

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@juanpedromoreno juanpedromoreno merged commit 95de45e into master Nov 7, 2017
@juanpedromoreno juanpedromoreno deleted the feature/avro-serialization branch November 7, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants