Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all users online list #29

Closed
wants to merge 31 commits into from
Closed

Fixed all users online list #29

wants to merge 31 commits into from

Conversation

luancschmitz
Copy link

I encountered a problem when using the allOnline method. He said the $filter method was not recognized. For this I changed the allOnline method of:

return $this->all()->filter->isOnline();

for this:

return $this->all()->filter(function( $users) {
            return $users->isOnline();
});

GabrielDeveloper and others added 23 commits May 30, 2016 22:55
Configuring Codacy and adding badges.
…with

laravel 5.3 version #hacktoberfest

- Add script test on composer.json

#8

Issue #8
- Changed method "boot" on UsersOnlineEventServiceProvider to comply …
 * New method to return all users online

 * README updated
 * Compatible with Laravel 5.4
@GabrielDeveloper
Copy link
Member

@luancschmitz what package version and laravel version that are you using?

@luancschmitz
Copy link
Author

luancschmitz commented Aug 2, 2017 via email

@luancschmitz
Copy link
Author

agora vi que você é brasileiro, Eu só modifiquei o código listado. Não conheço muito desse pull request, talvez eu tenha feito errada submissão do erro e a solução.

@GabrielDeveloper
Copy link
Member

If you are using an version less then 5.4 on Laravel, the method filter don't work, please read the README https://github.com/highideas/laravel-users-online/tree/2.0.0 to see how works on this version:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants