Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Support guide pages on mobile #351

Closed
jay-khatri opened this issue Feb 21, 2023 · 0 comments · Fixed by highlight/highlight#4736 · May be fixed by #449
Closed

Support guide pages on mobile #351

jay-khatri opened this issue Feb 21, 2023 · 0 comments · Fixed by highlight/highlight#4736 · May be fixed by #449
Assignees

Comments

@jay-khatri
Copy link
Contributor

we just added some new guides, for example: http://highlight.io/docs/getting-started/client-sdk/reactjs

we need to support mobile though, do you mind taking a crack at this?

Crawron added a commit to highlight/highlight that referenced this issue Apr 8, 2023
## Summary

Original PR, with a more detailed commit history
highlight/highlight.io#449

- [x] Stack code snippets in docs guide page in mobile. fix
highlight/highlight.io#351
- [x]  Guide page breaks bounds in mobile
- [x]  Docs header on mobile looks wrong

---

- [x]  Subheading in doc pages should be linked
- [x]  Heading ids in doc pages generate inconsistently
- [x]  Scrolling from right sidebar is “misaligned”

---

- [x] Left sidebar in docs should extend full viewport height. fix
highlight/highlight.io#444
- [x]  Title in landing page should have consistent padding
- [x]  Add a separator to docs header

---

- [x]  Automatically close menu on docs page in mobile
- [x]  Remove duplicated forward slashes in links

---

- [x] Pricing page and docs guides now expand properly on desktop. fix
#4780
- [ ] ~~Make any header linkable~~ (Ran into issues with this, not sure
how to fix it)
- [x] Prevent docs menu from overflowing the view
- [x] Add product links to page footer. fix #4753

---------

Co-authored-by: Vadim Korolik <vkorolik@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
2 participants