-
Notifications
You must be signed in to change notification settings - Fork 326
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
drop attribute that prevents cookies from being sent for asset request (
#8520) ## Summary As reported by Motion, ``` <link href="https://pri.highlight.io/assets/1079/91f4wuyZMOLJLcHQvjepfJVKYQxx1Rrv7PWSq7RJjZ8~" rel="stylesheet"> ``` loads correctly from our asset cache from app.highlight.io with the assets cookie, while ``` <link href="https://pri.highlight.io/assets/1079/_ZQLI9RtgPGhqFe1X1WDaigth52_TOp9ZNUmEenxIxY~" rel="modulepreload"> <link crossorigin="" href="https://pri.highlight.io/assets/1079/l4NeTC0Z_WRgQW7I6x9qBA22t1B6oVZk6XZFjBDgpoY~" rel="modulepreload"> ``` do not load because of the `rel="modulepreload"` attribute. We should drop the `rel` attribute as it is a performance optimization for page load that isn't required to play back the session. ## How did you test this change? unit testing in parse_test.go ## Are there any deployment considerations? monitoring motion deploy ## Does this work require review from our design team? no
- Loading branch information
Showing
4 changed files
with
53 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters