Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of firebase (at least for self-hosted) #3596

Closed
jay-khatri opened this issue Jan 25, 2023 · 0 comments · Fixed by #4133
Closed

Get rid of firebase (at least for self-hosted) #3596

jay-khatri opened this issue Jan 25, 2023 · 0 comments · Fixed by #4133
Assignees
@Vadman97

Comments

@jay-khatri
Copy link
Collaborator

No description provided.

@jay-khatri jay-khatri added this to the Open source preparation milestone Jan 25, 2023
@Vadman97 Vadman97 mentioned this issue Feb 3, 2023
Merged
@Vadman97 Vadman97 linked a pull request Feb 3, 2023 that will close this issue
add dummy simple auth for docker #4133
Merged
@jay-khatri jay-khatri removed this from the Open source preparation milestone Feb 4, 2023
Vadman97 added a commit that referenced this issue Feb 5, 2023
@Vadman97
add dummy simple auth for docker (#4133)
ce9f4a1 
## Summary

Since we don't want to require firebase to be set up for folks to
self-host hobby highlight,
this change provides a dummy auth used when hosting in docker that does
not require a username/password.

## How did you test this change?

Local deploy in docker and outside with the new env vars set.

## Are there any deployment considerations?

New backend middleware + frontend code path is only enabled if
`IN_DOCKER=true` and `REACT_APP_AUTH_MODE=simple`.

Closes #3596
@Vadman97 Vadman97 mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vadman97 Vadman97

Labels
None yet
Projects
Highlight Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dummy simple auth for docker highlight/highlight
2 participants
@Vadman97 @jay-khatri