HIG-314: Override Ant Design's variables and change Timeline annotation styles #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2021 13:38
|
Your Render PR Server URL is https://frontend-pr-543-tl9z.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1jo2f5ua9vq7q3ld8ig. |
JohnPhamous
commented
Apr 2, 2021
JohnPhamous
changed the title
HIG-314 Styling fixes to the indicator popups
A few thoughts on how the popups should look:
Sorry if you already have another task for this; this isn't high prio. |
jay-khatri
approved these changes
Apr 2, 2021
We could get rid of the arrow completely maybe? idk |
|
Ant Design has a 4 year old issue for the arrow :( ant-design/ant-design#7038 Removing the arrow. |
JohnPhamous
deleted the
john/hig-318-override-ant-designs-base-stylesheet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a sanity check around the app to make sure everything looks right.