New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release new sdk versions without jaeger dependency #6838
Merged
Vadman97
merged 2 commits into
main
from
6797-release-new-sdk-versions-without-jaeger-dependency
Oct 12, 2023
Merged
release new sdk versions without jaeger dependency #6838
Vadman97
merged 2 commits into
main
from
6797-release-new-sdk-versions-without-jaeger-dependency
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5c40b5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
deltaepsilon
approved these changes
Oct 11, 2023
Vadman97
deleted the
6797-release-new-sdk-versions-without-jaeger-dependency
branch
October 12, 2023 15:57
lewisl9029
pushed a commit
to lewisl9029/highlight
that referenced
this pull request
Nov 16, 2023
## Summary References new opentelemetry dependencies with open-telemetry/opentelemetry-js#4049 merged Explicitly makes `@opentelemetry/exporter-jaeger` a dev dependency so that consumers do not reference it in their bundle. ## How did you test this change? Local e2e app using yalc published SDK. repro app is working correctly https://discord.com/channels/1026884757667188757/1138948448507404338 ![image](https://github.com/highlight/highlight/assets/1351531/31b87688-d2de-40dc-80cf-c7946b5a1eee) ## Are there any deployment considerations? Changeset included. ## Does this work require review from our design team? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References new opentelemetry dependencies with open-telemetry/opentelemetry-js#4049 merged
Explicitly makes
@opentelemetry/exporter-jaeger
a dev dependency so that consumersdo not reference it in their bundle.
How did you test this change?
Local e2e app using yalc published SDK.
repro app is working correctly
https://discord.com/channels/1026884757667188757/1138948448507404338
Are there any deployment considerations?
Changeset included.
Does this work require review from our design team?
No