Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new sdk versions without jaeger dependency #6838

Merged

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Oct 10, 2023

Summary

References new opentelemetry dependencies with open-telemetry/opentelemetry-js#4049 merged
Explicitly makes @opentelemetry/exporter-jaeger a dev dependency so that consumers
do not reference it in their bundle.

How did you test this change?

Local e2e app using yalc published SDK.

repro app is working correctly
https://discord.com/channels/1026884757667188757/1138948448507404338
image

Are there any deployment considerations?

Changeset included.

Does this work require review from our design team?

No

@Vadman97 Vadman97 requested review from deltaepsilon and a team October 10, 2023 18:53
@Vadman97 Vadman97 linked an issue Oct 10, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: d5c40b5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

e2e/nextjs/package.json Show resolved Hide resolved
@Vadman97 Vadman97 merged commit 6833308 into main Oct 12, 2023
10 checks passed
@Vadman97 Vadman97 deleted the 6797-release-new-sdk-versions-without-jaeger-dependency branch October 12, 2023 15:57
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
## Summary

References new opentelemetry dependencies with
open-telemetry/opentelemetry-js#4049 merged
Explicitly makes `@opentelemetry/exporter-jaeger` a dev dependency so
that consumers
do not reference it in their bundle.

## How did you test this change?

Local e2e app using yalc published SDK.

repro app is working correctly
https://discord.com/channels/1026884757667188757/1138948448507404338

![image](https://github.com/highlight/highlight/assets/1351531/31b87688-d2de-40dc-80cf-c7946b5a1eee)

## Are there any deployment considerations?

Changeset included.

## Does this work require review from our design team?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release new sdk versions without jaeger dependency
2 participants