Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hobby deploy routing logs/traces to self #7709

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Feb 8, 2024

Summary

When running the hobby deploy with ./run-hobby.sh, logs and traces would be sent to the stack itself
rather than to our cloud collector (when telemetry was enabled) because of the default value of the
OTLP_ENDPOINT. Correct this to allow collecting phonehome telemetry data.
Fixes recent regression that would prevent local dev from recording sessions.

How did you test this change?

before
Screenshot 2024-02-08 at 12 34 33 PM

after
Screenshot 2024-02-08 at 12 36 29 PM

Screenshot 2024-02-08 at 12 36 17 PM

https://www.loom.com/share/90b4ade1a6c749af93d10b8b54cbd35e

Are there any deployment considerations?

no

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team February 8, 2024 20:36
Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 1aa39f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Vadman97 Vadman97 enabled auto-merge (squash) February 8, 2024 22:39
@Vadman97 Vadman97 merged commit 33ad55d into main Feb 8, 2024
11 checks passed
@Vadman97 Vadman97 deleted the vadim/hobby-deploy-fixes branch February 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants