-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hobby deploy routing logs/traces to self #7709
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
When running the hobby deploy with
./run-hobby.sh
, logs and traces would be sent to the stack itselfrather than to our cloud collector (when telemetry was enabled) because of the default value of the
OTLP_ENDPOINT
. Correct this to allow collecting phonehome telemetry data.Fixes recent regression that would prevent local dev from recording sessions.
How did you test this change?
before
after
https://www.loom.com/share/90b4ade1a6c749af93d10b8b54cbd35e
Are there any deployment considerations?
no
Does this work require review from our design team?
no