-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display exists values in search #7732
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'm noticing right away is that we show the message
attribute as always matching even when there are no filters.
Another problem I'm seeing is that if you use !=
all those attributes will still show up as matching still.
I'm guessing there are still some edge cases we'll run into with the new operators like !=
, but wondering if we want to keep the old logic for =
and maybe create new code paths for each operator to determine if it's matching?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
When a user is searching if attribute exists on a log row, there is no feedback to which rows are matching. Add support to display row when searching if an attribute exists.
How did you test this change?
Are there any deployment considerations?
N/A
Does this work require review from our design team?
N/A