Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error object embeddings #8144

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

mayberryzane
Copy link
Contributor

Summary

  • remove table / partition creation for error_object_embeddings_partitioned
  • remove reading / writing from error_object_embeddings_partitioned
  • also removes the find_similar_errors resolver - this demo page doesn't seem to be working in prod?

How did you test this change?

  • created errors from the buttons page, made sure they were grouped to existing error groups

Are there any deployment considerations?

  • can revert if issues, will drop the error_object_embeddings_partitioned tables after all looks good

Does this work require review from our design team?

  • no

Copy link

changeset-bot bot commented Mar 29, 2024

⚠️ No Changeset found

Latest commit: 037793a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane changed the title Zane/remove error object embeddings remove error object embeddings Mar 29, 2024
@mayberryzane mayberryzane requested review from a team and Vadman97 and removed request for a team March 29, 2024 21:27
@mayberryzane mayberryzane enabled auto-merge (squash) March 29, 2024 21:39
@mayberryzane mayberryzane merged commit da48ded into main Mar 29, 2024
13 checks passed
@mayberryzane mayberryzane deleted the zane/remove_error_object_embeddings branch March 29, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants