Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve small span display on flame graph #8207

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

ccschmitz
Copy link
Contributor

@ccschmitz ccschmitz commented Apr 8, 2024

Summary

Tweaks the display of really small spans on the trace flame graph.

  • Sets a minimum width for a span on the flame graph to make it easier to see and interact with spans that have a very short duration.
  • Fixes the duration display for spans that report a 0 duration.

The previews below are looking at this trace for reference.

Before
2024-04-08 16 09 57

After
2024-04-08 16 07 58

How did you test this change?

Click tested some traces in prod and contrasted them with the PR preview for the same trace (see before and after above).

Are there any deployment considerations?

N/A - client-side change only.

Does this work require review from our design team?

Will review the changes w/ Julian before merging.

Copy link

linear bot commented Apr 8, 2024

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 56550a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz ccschmitz changed the title Improve small trace display Improve small span display on flame graph Apr 8, 2024
@ccschmitz ccschmitz marked this pull request as ready for review April 9, 2024 11:25
@ccschmitz ccschmitz requested review from a team and SpennyNDaJets and removed request for a team April 9, 2024 14:46
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@ccschmitz ccschmitz merged commit 2fe5850 into main Apr 9, 2024
13 checks passed
@ccschmitz ccschmitz deleted the hig-4473-trace-duration-calculated-incorrectly branch April 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants