-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add position indicator in session logs #8280
Add position indicator in session logs #8280
Conversation
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview looks great! thank you for your contribution
I noticed that the arrow icon in the network logs doesn't function, whereas it works as a 'go-to' button in error logs. Is this intentional or does it need fixing?
not intentional - would you mind helping fix this?
I also noticed that when switching tabs, if I'm at a certain timestamp in one tab and then switch to another tab, the new tab doesn't automatically scroll to the current active log.(By tab i mean console, error and network tabs)
yup, i see that as well. would be great to fix that - looks like some useEffect
needs to fix on tab change to trigger a scroll on tab change?
Should i create a seperate pr for these or implement them here? @Vadman97 |
I will make the changes today. |
@Vadman97 as this is approved can you merge it I will create a new pr for the changes. |
@syedbarimanjan can you run yarn format:all to fix the lint errors? |
Did it @Vadman97 |
Head branch was pushed to by a user without write access
@Vadman97 I would like to further contribute to the project but most of the issues are created by a bot and are a link to linear which is making it hard to pick an issue. |
Summary
closes #4872
/claim #4872
I noticed that the arrow icon in the network logs doesn't function, whereas it works as a 'go-to' button in error logs. Is this intentional or does it need fixing?
I also noticed that when switching tabs, if I'm at a certain timestamp in one tab and then switch to another tab, the new tab doesn't automatically scroll to the current active log.(By tab i mean console, error and network tabs)
Screencast from 17-04-2024 10:58:45.webm
How did you test this change?
Screencast.from.17-04-2024.10.27.46.webm
Are there any deployment considerations?
None
Does this work require review from our design team?
No