Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap date picker on log alerts #8281

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Apr 17, 2024

Summary

The logs alert page was using the PreviousDateRangePicker, but needed to use the values from the query passed into it. Swap it out with the search DateRangePicker and use the useSearchTime hooks to allow updating the url.

https://www.loom.com/share/82611b06d77941cba8b46fa7cdba8424?sid=d008b64e-5711-44d5-bfe3-89cf482df085

How did you test this change?

  1. Make a log query in which the time is updated
  2. Create an alert from that query
  • Params get moved over correctly
  • Time is also ported over
  • Reloading the page will reset any changes to log queries original params
  • Time is held when reloading page

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 2ceea27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets requested review from a team and Vadman97 and removed request for a team April 17, 2024 16:04
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review April 17, 2024 16:04
__generated/rr/rrweb/rr.js Outdated Show resolved Hide resolved
@SpennyNDaJets SpennyNDaJets merged commit 639558b into main Apr 17, 2024
13 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/swap-date-picker-on-log-alerts branch April 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants