-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize kafka reader #8294
Merged
Merged
optimize kafka reader #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vadman97
requested review from
a team and
mayberryzane
and removed request for
a team
April 18, 2024 03:33
mayberryzane
approved these changes
Apr 18, 2024
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 18, 2024 16:56
247d812
to
f9ce57e
Compare
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 18, 2024 21:05
f9ce57e
to
fa6152b
Compare
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 19, 2024 22:53
760e759
to
033f660
Compare
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 22, 2024 18:23
033f660
to
dc4a466
Compare
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 23, 2024 05:06
4c31879
to
01c95c0
Compare
Vadman97
force-pushed
the
vadim/kafka-reader-tuning
branch
from
April 26, 2024 16:02
8998e70
to
d763773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the kafka reader
MaxWait
time to a larger value to allow pulling larger messages from kafka.See https://highlightcorp.slack.com/archives/C02CJANPHQS/p1713406197875469
Closes HIG-4286
How did you test this change?
manual deploy
Are there any deployment considerations?
deploy monitoring, see slack thread
Does this work require review from our design team?
no