Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize kafka reader #8294

Merged
merged 33 commits into from
Apr 26, 2024
Merged

optimize kafka reader #8294

merged 33 commits into from
Apr 26, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Apr 18, 2024

Summary

Updates the kafka reader MaxWait time to a larger value to allow pulling larger messages from kafka.
See https://highlightcorp.slack.com/archives/C02CJANPHQS/p1713406197875469

Closes HIG-4286

How did you test this change?

manual deploy

Are there any deployment considerations?

deploy monitoring, see slack thread

Does this work require review from our design team?

no

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: d763773

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 requested review from a team and mayberryzane and removed request for a team April 18, 2024 03:33
@Vadman97 Vadman97 marked this pull request as ready for review April 18, 2024 03:34
@Vadman97 Vadman97 enabled auto-merge (squash) April 26, 2024 16:03
@Vadman97 Vadman97 merged commit 411d0aa into main Apr 26, 2024
17 checks passed
@Vadman97 Vadman97 deleted the vadim/kafka-reader-tuning branch April 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants