Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall view for a trace #8295

Merged
merged 110 commits into from
May 1, 2024
Merged

Conversation

ccschmitz
Copy link
Contributor

@ccschmitz ccschmitz commented Apr 18, 2024

Summary

Adds a waterfall view of a trace alongside the flame graph. The waterfall view allows you to see all spans in a list and provides a visual of the duration a span takes on the right. It also allows you to filter the spans using the input at the top to quickly find a span of interest.

Screenshot 2024-04-30 at 4 10 31 PM

This PR also fixes an issue with orphan spans not being rendered on certain traces (HIG-4569).

How did you test this change?

  • Go to a span anywhere in the product
  • Click the "Waterfall" tab to switch from the flame graph to the waterfall view
  • Ensure the functionality of the visualization behaves as expected

Please note that lots of the noise in the diff is from a change to our sprinkles and the generated files.

Are there any deployment considerations?

N/A - all client-side changes.

Does this work require review from our design team?

Julian has already provided a round of feedback and provided mocks, but will have him click test as well!

Copy link

linear bot commented Apr 18, 2024

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 45e498b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz ccschmitz requested review from a team and mayberryzane and removed request for a team April 30, 2024 21:13
@ccschmitz ccschmitz marked this pull request as ready for review April 30, 2024 21:17
@ccschmitz ccschmitz changed the title Hig 4481 listwaterfall view for a trace Waterfall view for a trace May 1, 2024
Copy link
Contributor

@mayberryzane mayberryzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great in preview ✨

__generated/rr/rrweb/rr.js Outdated Show resolved Hide resolved
@ccschmitz ccschmitz enabled auto-merge (squash) May 1, 2024 18:53
@ccschmitz ccschmitz merged commit 7464bd1 into main May 1, 2024
21 checks passed
@ccschmitz ccschmitz deleted the hig-4481-listwaterfall-view-for-a-trace branch May 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants