-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waterfall view for a trace #8295
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great in preview ✨
…istwaterfall-view-for-a-trace
Summary
Adds a waterfall view of a trace alongside the flame graph. The waterfall view allows you to see all spans in a list and provides a visual of the duration a span takes on the right. It also allows you to filter the spans using the input at the top to quickly find a span of interest.
This PR also fixes an issue with orphan spans not being rendered on certain traces (HIG-4569).
How did you test this change?
Please note that lots of the noise in the diff is from a change to our sprinkles and the generated files.
Are there any deployment considerations?
N/A - all client-side changes.
Does this work require review from our design team?
Julian has already provided a round of feedback and provided mocks, but will have him click test as well!