Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert combobox changes #8303

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Revert combobox changes #8303

merged 1 commit into from
Apr 19, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

Summary

New flex value is causing combobox to collapse on words

Screenshot 2024-04-19 at 9 57 59 AM

How did you test this change?

Revert flex property

Are there any deployment considerations?

Need to add back solution for dashboards page

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: d7a1543

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review April 19, 2024 13:59
@SpennyNDaJets SpennyNDaJets requested review from a team and mayberryzane and removed request for a team April 19, 2024 13:59
@SpennyNDaJets
Copy link
Contributor Author

c.c. @mayberryzane just reverting this change for now since dashboards is behind toggle, but happy to work on a longer term solution

@SpennyNDaJets SpennyNDaJets merged commit 9fe3d02 into main Apr 19, 2024
13 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/revert-combobox-changes branch April 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants