-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out session query builder #8328
Conversation
|
## Summary Migrate the session segments into the new table for the new search experience Setup https://www.loom.com/share/05121714ea544dfab7e7567ed074ddff Confirmation https://www.loom.com/share/2eb271076a1e48ad8255e8c2a97a5e35 ## How did you test this change? 1) Create a session segment on the old UI 2) Run the task in dry run mode `doppler run -- go run backend/scripts/migrate-session-segments/main.go` - [ ] Segment not updated - [ ] Segment params look correct 3) Run the task in confirm mode ` doppler run -- go run backend/scripts/migrate-session-segments/main.go -confirm=true` - [ ] Segment updated - [ ] Segment params look correct - [ ] Able to load segment in new UI with same results ## Are there any deployment considerations? Run shortly before deploying #8328 ## Does this work require review from our design team? N/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + click test look great! Nice work on this, @SpennyNDaJets!!
One thing I'm noticing in the filter suggestions are some keys that aren't valid (see screenshot below).
![Screenshot 2024-04-30 at 2 26 06 PM](https://private-user-images.githubusercontent.com/308182/326955641-956e77ce-1f5e-4390-8e62-75c526bf8b9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAyNjk5ODYsIm5iZiI6MTcyMDI2OTY4NiwicGF0aCI6Ii8zMDgxODIvMzI2OTU1NjQxLTk1NmU3N2NlLTFmNWUtNDM5MC04ZTYyLTc1YzUyNmJmOGI5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwNlQxMjQxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZWRiYmVhN2Y1ZjM3ZjJmZTI3YmQ4MDcyZGE2NWEwNzQ1MmI3Y2FjNjdlN2ZmN2I3NTJmOTZhNDAxYzE4NzJlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PwjIdsw0VjivNU5E3tWYJkCSSUTwir1oyt9EpT4rZIk)
Maybe an issue with my local data, but wanted to mention it.
Wondering if we can/should prioritize cleaning up the dropdown list to make it more functional now that we're filtering sessions which could have a ton of filterable attributes. I also wonder if we should clean up things like the loc_state
filter you mentioned in your screencast 🤔 - not something to address in this PR, but perhaps dig into with @julian-highlight as a future improvement.
Looking great overall!
import { FrontContextProvider } from '@pages/FrontPlugin/Front/FrontContext' | ||
import { useEffect } from 'react' | ||
import { Helmet } from 'react-helmet' | ||
|
||
// TODO: fix this page |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Summary
Swap out the session query builder
Other notable changes/non-changes:
https://www.loom.com/share/aee3267d8f4e45008367515d70cb4b43?sid=bc3c843d-0b21-4b5c-9dd5-3ef4f42d5ca5
Closes HIG-4464
How did you test this change?
TBD
Are there any deployment considerations?
Must migrate saved searches before deploying
Does this work require review from our design team?
Yes