Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out session query builder #8328

Merged
merged 31 commits into from
May 2, 2024
Merged

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Apr 23, 2024

Summary

Swap out the session query builder

Other notable changes/non-changes:

  • Backend: swap out deleteSessions params for new search language
  • removes the session search context wrapper
  • moves the session saved searches to the new table
  • removes command bar
  • removes preloading sessions
  • does not edit ingestion filters

https://www.loom.com/share/aee3267d8f4e45008367515d70cb4b43?sid=bc3c843d-0b21-4b5c-9dd5-3ef4f42d5ca5

Closes HIG-4464

How did you test this change?

TBD

Are there any deployment considerations?

Must migrate saved searches before deploying

Does this work require review from our design team?

Yes

Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: c648634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets mentioned this pull request Apr 29, 2024
5 tasks
SpennyNDaJets added a commit that referenced this pull request Apr 29, 2024
## Summary
Migrate the session segments into the new table for the new search
experience

Setup
https://www.loom.com/share/05121714ea544dfab7e7567ed074ddff

Confirmation
https://www.loom.com/share/2eb271076a1e48ad8255e8c2a97a5e35

## How did you test this change?
1) Create a session segment on the old UI
2) Run the task in dry run mode `doppler run -- go run
backend/scripts/migrate-session-segments/main.go`
- [ ] Segment not updated
- [ ] Segment params look correct
3) Run the task in confirm mode ` doppler run -- go run
backend/scripts/migrate-session-segments/main.go -confirm=true`
- [ ] Segment updated
- [ ] Segment params look correct
- [ ] Able to load segment in new UI with same results

## Are there any deployment considerations?
Run shortly before deploying
#8328

## Does this work require review from our design team?
N/A
Copy link

linear bot commented Apr 29, 2024

Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + click test look great! Nice work on this, @SpennyNDaJets!!

One thing I'm noticing in the filter suggestions are some keys that aren't valid (see screenshot below).

Screenshot 2024-04-30 at 2 26 06 PM

Maybe an issue with my local data, but wanted to mention it.

Wondering if we can/should prioritize cleaning up the dropdown list to make it more functional now that we're filtering sessions which could have a ton of filterable attributes. I also wonder if we should clean up things like the loc_state filter you mentioned in your screencast 🤔 - not something to address in this PR, but perhaps dig into with @julian-highlight as a future improvement.

Looking great overall!

import { FrontContextProvider } from '@pages/FrontPlugin/Front/FrontContext'
import { useEffect } from 'react'
import { Helmet } from 'react-helmet'

// TODO: fix this page

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@SpennyNDaJets SpennyNDaJets merged commit 82fb146 into main May 2, 2024
21 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/migrate-sessions-search branch May 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants