Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with invite modal #8404

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

ccschmitz
Copy link
Contributor

Summary

Fixes a few issues with our member invite modal.

  • Resets the form after successful submission
  • Fixes the auto focus on the email input after successful submission
  • Removes the alert if you close and reopen the modal

How did you test this change?

Click tested the following locally and in the PR preview.

  • Invite a team member and ensure
    • Email input was reset
    • Email input was focused
    • Closing and reopening the modal does not show the alert

Are there any deployment considerations?

N/A - all minor client-side changes

Does this work require review from our design team?

N/A

* Resets the form after successful submission
* Fixes the auto focus on the email input after successful submission
* Removes the alert if you close and reopen the modal
Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 793a458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz ccschmitz requested review from a team and SpennyNDaJets and removed request for a team April 30, 2024 21:54
@ccschmitz ccschmitz marked this pull request as ready for review April 30, 2024 21:54
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Saw a couple things, but also can handle in this card: https://linear.app/highlight/issue/HIG-4580/member-invite-email-is-case-sensitive

  1. It looks like it sent to emails the first time to Spencer22309@gmail.com
    Screenshot 2024-05-01 at 9 38 42 AM

  2. I was able to send an email to an empty email
    Screenshot 2024-05-01 at 9 39 39 AM

@ccschmitz
Copy link
Contributor Author

@SpennyNDaJets thanks for catching that! Happy to grab that follow up ticket!

@ccschmitz ccschmitz merged commit 28de613 into main May 1, 2024
21 checks passed
@ccschmitz ccschmitz deleted the hig-4477-invite-member-modal branch May 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants