Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow issues on metrics table #8448

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented May 2, 2024

Summary

How did you test this change?

  • clicktested locally

Are there any deployment considerations?

  • no

Does this work require review from our design team?

Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: 6aba9e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane requested review from a team and Vadman97 and removed request for a team May 2, 2024 22:09
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Summary

  • Overflow Fixes: Implemented solutions to prevent overflow and wrapping in the metrics table's headers and rows, enhancing UI stability.
  • Column Visibility: Ensured the first column's minimum width is set, keeping timestamps fully visible and improving data readability.
  • UI Integrity: Adjustments made to address funky dashboard grid sizes caused by an overflowing table, aiming for a more consistent and user-friendly layout.

Potential Pitfalls and Notes

  • Styling Impact: Ensure the CSS changes do not negatively impact other tables or components with shared styles, to avoid unintended layout shifts.
  • Code Reuse: Opportunities for code reuse in similar components might arise, promoting consistency across the platform.
  • Design Review: Awaiting feedback from the design team to confirm these changes align with overall UI/UX goals.

Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview looks great

@mayberryzane mayberryzane enabled auto-merge (squash) May 3, 2024 00:05
@mayberryzane mayberryzane merged commit 92313c3 into main May 3, 2024
21 checks passed
@mayberryzane mayberryzane deleted the zane/table_overflow branch May 3, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants