-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overflow issues on metrics table #8448
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Summary
- Overflow Fixes: Implemented solutions to prevent overflow and wrapping in the metrics table's headers and rows, enhancing UI stability.
- Column Visibility: Ensured the first column's minimum width is set, keeping timestamps fully visible and improving data readability.
- UI Integrity: Adjustments made to address funky dashboard grid sizes caused by an overflowing table, aiming for a more consistent and user-friendly layout.
Potential Pitfalls and Notes
- Styling Impact: Ensure the CSS changes do not negatively impact other tables or components with shared styles, to avoid unintended layout shifts.
- Code Reuse: Opportunities for code reuse in similar components might arise, promoting consistency across the platform.
- Design Review: Awaiting feedback from the design team to confirm these changes align with overall UI/UX goals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview looks great
Summary
https://www.loom.com/share/2c74bffe247343c4a63a5bad915b75ac
https://www.loom.com/share/b1b49e18da3542db8fec8b7c21897509
How did you test this change?
Are there any deployment considerations?
Does this work require review from our design team?