improvement to errors_joined_vw perf

[mayberryzane]

Summary

• small change to errors_joined_vw replaces the line
  SELECT eg.ProjectID as ProjectId, with SELECT ProjectID as ProjectId,
  • this filters using the error_objects' primary key, and since it is the larger table in the join this makes a big perf difference
• also remove a where clause that was only to handle some bad data
  • in the process of deleting this data (~250 error groups) with the following:

CREATE TABLE errors_to_delete
(
    `ID` Int64,
    `CreatedAt` DateTime64(6)
)
ORDER BY (ID, CreatedAt)

INSERT INTO errors_to_delete
SELECT ID, CreatedAt
FROM default.error_groups
WHERE (ID, CreatedAt) NOT IN (
    SELECT
        ID,
        max(CreatedAt)
    FROM default.error_groups
    GROUP BY ID
)

DELETE
FROM default.error_groups
WHERE (ID, CreatedAt) IN (
    SELECT
        ID,
        CreatedAt FROM
    errors_to_delete
) SETTINGS allow_nondeterministic_mutations=1

How did you test this change?

• created a new view and tested query perf against it

Are there any deployment considerations?

• will wait to confirm those ~250 error groups are deleted

Does this work require review from our design team?

• no

[changeset-bot]

⚠️ No Changeset found

Latest commit: d02e0ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

[Vadman97]

don't quite understand why we had those duplicate error groups with the same id... but the view change looks great

[mayberryzane]

don't quite understand why we had those duplicate error groups with the same id... but the view change looks great

@Vadman97 I think there was a change at some point to send higher granularity timestamps w/ microsecond instead of second precision, and because CreatedAt is part of the order by key, for some error groups we ended up w/ two rows