Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking js script #8458

Merged
merged 1 commit into from
May 3, 2024
Merged

Add tracking js script #8458

merged 1 commit into from
May 3, 2024

Conversation

jay-khatri
Copy link
Collaborator

@jay-khatri jay-khatri commented May 3, 2024

Summary

Add tracking js script + fix launch week links.

How did you test this change?

Are there any deployment considerations?

Does this work require review from our design team?

@jay-khatri jay-khatri requested a review from Vadman97 May 3, 2024 21:43
Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: 33c3e0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 enabled auto-merge (squash) May 3, 2024 21:44
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Summary

  • Updated Video URL: The URL for the launch video in the blog post about cohesion has been updated to a new YouTube link. This ensures readers have access to the correct and relevant video content.
  • Added Tracking Script: A new tracking script (rb2b-script) has been introduced in _document.js for enhanced tracking and analytics. The script loads asynchronously to minimize impact on page load performance.

Potential Pitfalls and Notes

  • Video URL: Ensure the new YouTube link is correct, publicly accessible, and relevant to the blog post content.
  • Tracking Script:
    • Verify the source of the rb2b-script to ensure compliance with privacy policies.
    • Assess the script's impact on user experience, particularly in terms of privacy and page load times.
  • Opportunities for Code Reuse: The asynchronous script loading approach used for the tracking script could be applied to other external scripts to improve performance across the site.

blog-content/lw5-d4-cohesion.md Show resolved Hide resolved
highlight.io/pages/_document.js Show resolved Hide resolved
highlight.io/pages/_document.js Show resolved Hide resolved
highlight.io/pages/_document.js Show resolved Hide resolved
highlight.io/pages/_document.js Show resolved Hide resolved
@Vadman97 Vadman97 merged commit 7efb6e7 into main May 3, 2024
20 checks passed
@Vadman97 Vadman97 deleted the jay-khatri-add-script branch May 3, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants