-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking js script #8458
Add tracking js script #8458
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Summary
- Updated Video URL: The URL for the launch video in the blog post about cohesion has been updated to a new YouTube link. This ensures readers have access to the correct and relevant video content.
- Added Tracking Script: A new tracking script (
rb2b-script
) has been introduced in_document.js
for enhanced tracking and analytics. The script loads asynchronously to minimize impact on page load performance.
Potential Pitfalls and Notes
- Video URL: Ensure the new YouTube link is correct, publicly accessible, and relevant to the blog post content.
- Tracking Script:
- Verify the source of the
rb2b-script
to ensure compliance with privacy policies. - Assess the script's impact on user experience, particularly in terms of privacy and page load times.
- Verify the source of the
- Opportunities for Code Reuse: The asynchronous script loading approach used for the tracking script could be applied to other external scripts to improve performance across the site.
Summary
Add tracking js script + fix launch week links.
How did you test this change?
Are there any deployment considerations?
Does this work require review from our design team?