Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric polling #8494

Merged
merged 7 commits into from
May 8, 2024
Merged

Metric polling #8494

merged 7 commits into from
May 8, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented May 7, 2024

Summary

Add polling to the metrics page to refresh data every minute

https://www.loom.com/share/d520058cc11d4437929ab0acdf8c779c

How did you test this change?

  1. Load the metrics page with a preset time (i.e. "Last 15 minutes")
  • Metrics are refreshed after ~1 minute (starts after successfully receiving metrics)
  • Metrics are refreshed after another ~1 minute (starts after successfully receiving metrics)
  1. Change the time to a fixed time range
  • Metrics are not refreshed after a minute
  1. Change time back to a preset time
  • Metrics are refreshed after ~1 minute (starts after successfully receiving metrics)
  1. Expanded a graph
  • Metrics are refreshed after ~1 minute (starts after successfully receiving metrics)
  1. Edit a graph
  • Metrics are refreshed after ~1 minute (starts after successfully receiving metrics)

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 932ad51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review May 8, 2024 15:59
@SpennyNDaJets SpennyNDaJets requested review from a team, Vadman97 and mayberryzane and removed request for a team May 8, 2024 15:59
@SpennyNDaJets SpennyNDaJets merged commit 92db61d into main May 8, 2024
21 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/metrics-polling branch May 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants