Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reliability of otel export #8495

Merged
merged 17 commits into from
May 8, 2024
Merged

improve reliability of otel export #8495

merged 17 commits into from
May 8, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented May 7, 2024

Summary

  • Fixes some panics in our backend discovered when debugging otel collector export errors
  • Adds noop support for /metrics export to prevent collector from erroring
  • Improves the export of spans from python by reducing batch size to help with timeouts
  • Improves Go SDK to report panics from middleware

How did you test this change?

before
Screenshot from 2024-05-07 12-35-22

after
Screenshot from 2024-05-07 12-35-10

Screenshot from 2024-05-07 18-08-21
Screenshot from 2024-05-07 18-09-26

Are there any deployment considerations?

new python sdk version

Does this work require review from our design team?

no

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: e7edb88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 changed the title Vadim/python otel improve reliability of otel export May 7, 2024
@Vadman97 Vadman97 requested review from a team and SpennyNDaJets and removed request for a team May 7, 2024 19:39
@Vadman97 Vadman97 marked this pull request as ready for review May 7, 2024 19:39
Copy link
Contributor

github-actions bot commented May 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
570 501 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
sdk/highlight-py/highlight_io/sdk.py 90% 🟢
TOTAL 90% 🟢

updated for commit: e7edb88 by action🐍

@Vadman97 Vadman97 merged commit 3d0de54 into main May 8, 2024
27 checks passed
@Vadman97 Vadman97 deleted the vadim/python-otel branch May 8, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants