Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support visualizing trace metrics #8500

Merged
merged 13 commits into from
May 11, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented May 8, 2024

Summary

Shows trace metric event keys as graphable keys in the metrics UI.
This will allow creating a web vitals dashboard.

How did you test this change?

Screenshot from 2024-05-09 18-28-08

Screenshot from 2024-05-09 18-28-34

Are there any deployment considerations?

when we extract metrics into their own product in the future, we should
refactor to remove some of this logic.

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and mayberryzane and removed request for a team May 8, 2024 00:37
Copy link

linear bot commented May 8, 2024

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: ac4f696

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97
Copy link
Member Author

@mayberryzane updated per your feedback!

frontend/src/pages/Billing/utils/utils.ts Dismissed Show dismissed Hide dismissed
frontend/src/pages/Billing/UpdatePlanPage.tsx Dismissed Show dismissed Hide dismissed
@Vadman97 Vadman97 force-pushed the hig-4611-allow-visualizing-trace-metric-events branch from 052227b to ac4f696 Compare May 10, 2024 23:34
@Vadman97 Vadman97 merged commit 20b94bb into main May 11, 2024
21 checks passed
@Vadman97 Vadman97 deleted the hig-4611-allow-visualizing-trace-metric-events branch May 11, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants