Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUP-9] fix vercel workflow for unauthed users #8517

Merged
merged 1 commit into from
May 10, 2024

Conversation

mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented May 9, 2024

Summary

  • users who need to log in / sign up to highlight see a blank screen while going through the Vercel integration installation starting in Vercel
  • fix this by going through the auth workflow, then redirecting back to the callback

How did you test this change?

  • tested these cases in preview:
    • already signed in - shown vercel settings in modal
    • not signed in, account created - sign in, then redirected to vercel settings
    • not signed in, no account - sign up, go through onboarding, then redirected to vercel settings

Are there any deployment considerations?

  • no

Does this work require review from our design team?

  • no

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 1193c1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane requested review from a team and Vadman97 and removed request for a team May 9, 2024 17:36
@mayberryzane mayberryzane changed the title fix vercel workflow for unauthed users [SUP-9] fix vercel workflow for unauthed users May 9, 2024
Copy link

linear bot commented May 9, 2024

@mayberryzane mayberryzane merged commit 183e0b5 into main May 10, 2024
21 checks passed
@mayberryzane mayberryzane deleted the zane/vercel_onboarding_fix branch May 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants